-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(router): modify net_amount
to be a struct in the domain model of payment_attempt and handle amount changes across all flows
#6323
Merged
bernard-eugine
merged 2 commits into
hotfix-2024.10.04.0
from
net-amount-refactor-hotfix
Oct 15, 2024
Merged
refactor(router): modify net_amount
to be a struct in the domain model of payment_attempt and handle amount changes across all flows
#6323
bernard-eugine
merged 2 commits into
hotfix-2024.10.04.0
from
net-amount-refactor-hotfix
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…del of payment_attempt and handle amount changes across all flows (#6252) Co-authored-by: swangi-kumari <swangi.12015941@lpu.in> Co-authored-by: Swangi Kumari <85639103+swangi-kumari@users.noreply.github.com> Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
hyperswitch-bot
bot
added
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Oct 15, 2024
Narayanbhat166
approved these changes
Oct 15, 2024
Aprabhat19
approved these changes
Oct 15, 2024
SanchithHegde
approved these changes
Oct 15, 2024
Comment on lines
+867
to
+868
surcharge_amount, | ||
tax_amount, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we allow updating surcharge and tax amounts without updating net amount? Should we include net_amount
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will take up this fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-core
Area: Core flows
C-refactor
Category: Refactor
M-api-contract-changes
Metadata: This PR involves API contract changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
modify
net_amount
to be a struct in the domain model of payment_attempt and handle amount changes across all flowsMain PR - #6252
Additional Changes
Motivation and Context
How did you test it?
Test cases in main PR
Checklist
cargo +nightly fmt --all
cargo clippy