-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add payments post_session_tokens flow #6326
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
hyperswitch-bot
bot
added
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Oct 15, 2024
swangi-kumari
added
A-connector-integration
Area: Connector integration
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
C-refactor
Category: Refactor
labels
Oct 15, 2024
apoorvdixit88
approved these changes
Oct 15, 2024
tsdk02
approved these changes
Oct 15, 2024
deepanshu-iiitu
approved these changes
Oct 15, 2024
Narayanbhat166
approved these changes
Oct 15, 2024
SanchithHegde
approved these changes
Oct 15, 2024
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-connector-integration
Area: Connector integration
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
C-refactor
Category: Refactor
M-api-contract-changes
Metadata: This PR involves API contract changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
hotfix for PR
Use Case
/confirm
call, and in response, we received theorder_id
/connector_transaction_id
. We would then send this information to the HS SDK, which forwarded it to PayPal. PayPal used this data to render their SDK, allowing the user to log in and modify the shipping address. The user would then click "Complete Purchase," triggering the OnApprove callback, which was handled by the /complete_authorize call.Additional Changes
Motivation and Context
How did you test it?
Response
In Response Check for Next action - It should be
post_session_tokens
Response
Response
In Response Check for Next action - It should be confirm
Response
For end to end testing, we need to do the payment via SDK
Checklist
cargo +nightly fmt --all
cargo clippy