Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): [Adyen] Add MYR currency config #6442

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

srujanchikke
Copy link
Contributor

@srujanchikke srujanchikke commented Oct 27, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR have following changes

  • Add MYR to currency config for adyen
  • change default error code as UE_9000 to UE_000

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

This PR has following changes

  • Add MYR currency config
  • Change default error code to UE_9000 to UE_000 (This needs data migrations in translation table to provide support for localization).

Motivation and Context

How did you test it?

  • Test applepay via adyen connector with currency MYR. This is already tested with custom deployment.
Screenshot 2024-10-28 at 11 33 06 AM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@srujanchikke srujanchikke added the A-connector-integration Area: Connector integration label Oct 27, 2024
@srujanchikke srujanchikke self-assigned this Oct 27, 2024
@srujanchikke srujanchikke requested a review from a team as a code owner October 27, 2024 11:25
Copy link

semanticdiff-com bot commented Oct 27, 2024

Review changes with SemanticDiff.

Analyzed 1 of 6 files.

Filename Status
✔️ crates/router/src/consts.rs Analyzed
config/development.toml Unsupported file format
config/docker_compose.toml Unsupported file format
config/deployments/integration_test.toml Unsupported file format
config/deployments/production.toml Unsupported file format
config/deployments/sandbox.toml Unsupported file format

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Oct 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 28, 2024
@srujanchikke srujanchikke added the M-configuration-changes Metadata: This PR involves configuration changes label Oct 28, 2024
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Oct 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 28, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Oct 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 28, 2024
@SanchithHegde SanchithHegde merged commit 925e424 into main Oct 28, 2024
15 of 17 checks passed
@SanchithHegde SanchithHegde deleted the default_unified_error_code branch October 28, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration M-configuration-changes Metadata: This PR involves configuration changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants