fix(connector): [fiuu]fix mandates for fiuu #6487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srujanchikke
added
A-connector-integration
|
Review changes with Changed Files
|
awasthi21
previously approved these changes
Nov 6, 2024
awasthi21
previously approved these changes
Nov 7, 2024
Aprabhat19
reviewed
Nov 7, 2024
| let is_cit_transaction = pa.mandate_details.is_some() | ||
| || setup_future_usage | ||
| .map(|future_usage| future_usage == common_enums::enums::FutureUsage::OffSession) | ||
| .unwrap_or(false); |
There was a problem hiding this comment.
Can you move this variable out of the if let scope and replace the other check happening under this variable
deepanshu-iiitu
approved these changes
Nov 7, 2024
prajjwalkumar17
approved these changes
Nov 8, 2024
|
@srujanchikke Fix is required for cypress test to pass(Mandate flow with mandate id). Please assign someone or you can take this as seperate PR. As of now ill merge this. CC : @pranav-arjunan |
Gnanasundari24
approved these changes
Nov 8, 2024
SanchithHegde
removed
the
S-waiting-on-review
pixincreate
reviewed
Nov 11, 2024
Comment on lines
+655
to
+668
| billing: { | ||
| address: { | ||
| line1: "1467", | ||
| line2: "Harrison Street", | ||
| line3: "Harrison Street", | ||
| city: "San Fransico", | ||
| state: "California", | ||
| zip: "94122", | ||
| country: "NL", | ||
| first_name: "joseph", | ||
| last_name: "Doe", | ||
| }, | ||
| email: "johndoe@gmail.com" | ||
| }, |
There was a problem hiding this comment.
this could have been an object instead :/
bsayak03
pushed a commit
that referenced
this pull request
Nov 26, 2024
Co-authored-by: Chikke Srujan <chikke.srujan@Chikke-Srujan-N7WRTY72X7.local> Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
bsayak03
pushed a commit
that referenced
this pull request
Nov 26, 2024
Co-authored-by: Chikke Srujan <chikke.srujan@Chikke-Srujan-N7WRTY72X7.local> Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR fixes following things
-> Required fileds for mandates for fiuu
-> fix check for required fileds for mandates
-> add 3ds cypress 3ds test case
Additional Changes
Motivation and Context
How did you test it?
added cypress tests
Checklist
cargo +nightly fmt --allcargo clippy