-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(cypress): Add Checkout Connector #6559
Conversation
Changed Files
|
ZeroAuthMandate: { | ||
Response: { | ||
status: 501, | ||
body: { | ||
error: { | ||
type: "invalid_request", | ||
message: "Setup Mandate flow for Checkout is not implemented", | ||
code: "IR_00", | ||
}, | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we move this to commons
and remove the same from all configs?
we can directly use connectorName
within commons
to dynamically modify the error message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pixincreate Let's add this in the to-dos, and we can handle changes for all connectors in a separate PR. Updating all connectors at once would require testing each one individually, so we'll treat this as a separate task
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that's what even i want to do. lets have it as a separate pr so that only that area will be focused.
// Don't continue if payment status is processing during auto capture | ||
// Payment data is tokenized only after payment is successful | ||
let notProcessing = res_data?.body?.status != "processing"; | ||
should_continue = | ||
notProcessing && utils.should_continue_further(res_data); | ||
should_continue = utils.should_continue_further(res_data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this reverted? this was added by @kashif-m to add support for WorldPay. Removing this would result in WorldPay tests failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If status is processing after the payment confirm we cannot skip the next test cases because Psync call would make payment success and save card flow to work , we need to handle worldpay in a different way.
Type of Change
Description
Add Checkout Connector for Cypress Automation
Additional Changes
Motivation and Context
Checkout connector was not available in the cypress automation
How did you test it?
Cypress Tests
Checklist
cargo +nightly fmt --all
cargo clippy