Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(cypress): Add Checkout Connector #6559

Merged
merged 3 commits into from
Nov 15, 2024
Merged

ci(cypress): Add Checkout Connector #6559

merged 3 commits into from
Nov 15, 2024

Conversation

likhinbopanna
Copy link
Contributor

@likhinbopanna likhinbopanna commented Nov 13, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add Checkout Connector for Cypress Automation

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Checkout connector was not available in the cypress automation

How did you test it?

Cypress Tests

  • Checkout
image
  • NMI
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@likhinbopanna likhinbopanna requested a review from a team as a code owner November 13, 2024 13:36
Copy link

semanticdiff-com bot commented Nov 13, 2024

@likhinbopanna likhinbopanna linked an issue Nov 13, 2024 that may be closed by this pull request
@likhinbopanna likhinbopanna self-assigned this Nov 13, 2024
@likhinbopanna likhinbopanna added A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 13, 2024
@likhinbopanna likhinbopanna added this to the November 2024 Release milestone Nov 13, 2024
cypress-tests/cypress/e2e/PaymentUtils/Checkout.js Outdated Show resolved Hide resolved
Comment on lines +220 to +230
ZeroAuthMandate: {
Response: {
status: 501,
body: {
error: {
type: "invalid_request",
message: "Setup Mandate flow for Checkout is not implemented",
code: "IR_00",
},
},
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we move this to commons and remove the same from all configs?
we can directly use connectorName within commons to dynamically modify the error message.

Copy link
Contributor

@Gnanasundari24 Gnanasundari24 Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pixincreate Let's add this in the to-dos, and we can handle changes for all connectors in a separate PR. Updating all connectors at once would require testing each one individually, so we'll treat this as a separate task

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's what even i want to do. lets have it as a separate pr so that only that area will be focused.

cypress-tests/cypress/e2e/PaymentUtils/Checkout.js Outdated Show resolved Hide resolved
// Don't continue if payment status is processing during auto capture
// Payment data is tokenized only after payment is successful
let notProcessing = res_data?.body?.status != "processing";
should_continue =
notProcessing && utils.should_continue_further(res_data);
should_continue = utils.should_continue_further(res_data);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this reverted? this was added by @kashif-m to add support for WorldPay. Removing this would result in WorldPay tests failing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If status is processing after the payment confirm we cannot skip the next test cases because Psync call would make payment success and save card flow to work , we need to handle worldpay in a different way.

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@pixincreate pixincreate added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit 0b63efb Nov 15, 2024
17 checks passed
@pixincreate pixincreate deleted the checkout-cypress branch November 15, 2024 06:20
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI-CD Area: Continuous Integration/Deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CYPRESS] : Add Checkout Connector
4 participants