-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(router): refactor ctp flow to fetch mca_id and get the connector creds instead of connector_name #6859
Open
sahkal
wants to merge
15
commits into
main
Choose a base branch
from
7862-refactor-refactor-ctp-flow-to-fetch-mca_id-and-get-the-connector-creds-instead-of-connector_name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
sahkal
requested review from
sai-harsha-vardhan,
SanchithHegde and
ShankarSinghC
December 17, 2024 10:55
…2-refactor-refactor-ctp-flow-to-fetch-mca_id-and-get-the-connector-creds-instead-of-connector_name
sahkal
added
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Dec 20, 2024
sahkal
requested review from
jarnura
and removed request for
a team and
deepanshu-iiitu
December 20, 2024 07:45
jarnura
requested changes
Dec 20, 2024
crates/hyperswitch_domain_models/src/merchant_connector_account.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_domain_models/src/merchant_connector_account.rs
Outdated
Show resolved
Hide resolved
…_id-and-get-the-connector-creds-instead-of-connector_name
…-the-connector-creds-instead-of-connector_name' of https://github.com/juspay/hyperswitch into 7862-refactor-refactor-ctp-flow-to-fetch-mca_id-and-get-the-connector-creds-instead-of-connector_name
sai-harsha-vardhan
approved these changes
Dec 23, 2024
…_id-and-get-the-connector-creds-instead-of-connector_name
jarnura
approved these changes
Dec 23, 2024
sahkal
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
refactor ctp flow to fetch mca_id and get the connector creds instead of connector_name
How did you test it?
Add config to make the merchant eligible for authentication service
Create merchant connector account for Ctp_mastercard
Adyen
update business profile with ctp_mastercard mca_id
do payments create
do payments confirm
Expected Response
Checklist
cargo +nightly fmt --all
cargo clippy