feat(cypress): valdiate error_code and error_message and make it visible in reports
#6913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixincreate
added
A-CI-CD
|
Review changes with |
jagan-jaya
requested changes
Dec 23, 2024
… functino for reusing functions added in `commands.js` will be moved to a separate folder file and possibly take out some of the functions from `Utils.js`
jagan-jaya
approved these changes
Dec 23, 2024
Gnanasundari24
approved these changes
Dec 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
re-adding to queue. i had to re-run ci test since it came out of queue due to failure of cypress test |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
pixincreate
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR introduces error code and error message validations.
This nullifies the need to re-run the ci check manually in local every the check just to see the reason for the failure.
With that,
error_codeanderror_messagewill now be printed in the ui in every run and hence, this makes the generated reports more reliable.Additional Changes
Motivation and Context
i want reports to serve a purpose and reliable.
How did you test it?
when a ci check fail, especially from the connectors' end, ci takes a screenshot of the ui, as usual, but that will now contain the error code and message.
since adyen yet again got into some issues with save card flow, it is possible to test my changes directly without the need to make any modifications to the test:
Checklist
prettier . --writecargo clippy