chore(postman): postman tests fixes #7159
Conversation
|
Review changes with |
arindam-sahoo
changed the title
arindam-sahoo
changed the title
| @@ -48,6 +48,7 @@ | |||
| }, | |||
| "test_mode": false, | |||
| "disabled": false, | |||
| "metadata": {}, | |||
There was a problem hiding this comment.
Without the metadata field, it responds like the following
I tried creating the Payment Connector in the dashboard and saw that even passing {} as the value of the metadata field works, so added the "metadata": {},
| function () { | ||
| pm.expect(jsonData.status).to.eql("succeeded"); | ||
| pm.expect(jsonData.status).to.eql("processing"); |
There was a problem hiding this comment.
Manual Captures are staying in processing state.
Even sending PSync Request also responds processing as the status.
| @@ -51,7 +51,7 @@ | |||
| "card_number": "4111111111111111", | |||
| "card_exp_month": "03", | |||
| "card_exp_year": "2030", | |||
| "card_holder_name": "CLBRW1", | |||
There was a problem hiding this comment.
Adding a string without space between considers it as the first name and responds in the following way
With the following error details
| @@ -51,7 +51,7 @@ | |||
| "card_number": "4111111111111111", | |||
| "card_exp_month": "03", | |||
| "card_exp_year": "2030", | |||
| "card_holder_name": "CLBRW1", | |||
| "card_holder_name": "Juspay Hyperswitch", | |||
There was a problem hiding this comment.
Adding a space in the string solves the issue,
| if (jsonData?.amount) { | ||
| pm.test( | ||
| "[post]:://payments/:id/capture - Content check if value for 'amount_capturable' matches 'amount - 0'", | ||
| function () { | ||
| pm.expect(jsonData.amount_capturable).to.eql(0); | ||
| pm.expect(jsonData.amount_capturable).to.eql(jsonData.amount); |
There was a problem hiding this comment.
Due to the reason that Payments Captured Manually are staying in processing, the amount_capturable will be equal to the full amount.
| pm.response.to.be.success; | ||
| // Validate status 4xx | ||
| pm.test("[POST]::/refunds - Status code is 4xx", function () { | ||
| pm.response.to.have.status(400); |
There was a problem hiding this comment.
Payments - Retrieve-copy responding the status as processing, this is the error responded by Refunds - Create
| @@ -24,6 +24,13 @@ if (jsonData?.refund_id) { | |||
| jsonData.refund_id, | |||
| ); | |||
| } else { | |||
| pm.collectionVariables.set("refund_id", null); | |||
There was a problem hiding this comment.
Due to the reason that Refunds are not able to get created because of the above mentioned reason, the value of refund_id could not be set using:
pm.collectionVariables.set("refund_id", jsonData.refund_id);So, it takes the most recent value of refund_id which it gets from /postman/collection-dir/cybersource/Flow Testcases/Happy Cases/Scenario9-Add card flow/Refunds - Create/request.json.
| pm.test( | ||
| "[POST]::/refunds - Content check if 'error.message' matches 'This Payment could not be refund because it has a status of processing. The expected state is succeeded, partially_captured'", | ||
| function () { | ||
| pm.expect(jsonData.error.message).to.eql("This Payment could not be refund because it has a status of processing. The expected state is succeeded, partially_captured"); |
There was a problem hiding this comment.
Mapped the error message accordingly for not being able to create a refund.
| @@ -40,7 +27,7 @@ if (jsonData?.status) { | |||
| } | |||
|
|
|||
| // Response body should have value "6540" for "amount" | |||
| if (jsonData?.status) { | |||
| if (jsonData?.status && pm.collectionVariables.get("refund_id") !== null) { | |||
There was a problem hiding this comment.
This assertion was failing due to the refund_id issue in the Refunds - Create. Because it was assigned with the refund_id value of Scenario9-Add card flow/Refunds - Create which had the amount of 600, the assertion in this conditional statement was failing expecting it to be 540 according to the request created in Scenario11-Save card payment with manual capture
…nd add error message check for refunds
| @@ -40,7 +40,7 @@ | |||
| "card": { | |||
| "card_number": "4242424242424242", | |||
| "card_exp_month": "01", | |||
| "card_exp_year": "25", | |||
There was a problem hiding this comment.
January 2025 is no more a valid expiration.
| @@ -40,7 +40,7 @@ | |||
| "card": { | |||
| "card_number": "4242424242424242", | |||
| "card_exp_month": "01", | |||
| "card_exp_year": "25", | |||
| "card_exp_year": "35", | |||
There was a problem hiding this comment.
So, changed it to January 2035.
| pm.test( | ||
| "[POST]::/refunds - Content check if value for 'error.message' matches 'Refund does not exist in our records.'", | ||
| function () { | ||
| pm.expect(jsonData.error.message).to.eql("Refund does not exist in our records."); |
There was a problem hiding this comment.
Added an assertion to check the Error Message.
| @@ -36,7 +36,7 @@ if (jsonData?.error?.message) { | |||
| pm.test( | |||
| "[POST]::/payments/:id/confirm - Content check if value for 'error.reason' matches ' mandate payment is not supported by nmi'" , | |||
| function () { | |||
| pm.expect(jsonData.error.reason).to.eql(" mandate payment is not supported by nmi"); | |||
| pm.expect(jsonData.error.reason).to.eql("credit mandate payment is not supported by nmi"); | |||
… cases for trustpay connector
|
|
||
| // Add a delay of 10 seconds after the last | ||
| setTimeout(function () { | ||
| console.log("Delay of 10 seconds completed."); |
There was a problem hiding this comment.
Refunds were failing with
"error_message": "unspecified error",
"error_code": "No error code",
"unified_code": "UE_9000",
"unified_message": "Something went wrong"because of immediate refund of payment confirmed, giving a delay ensures successful Refund.
Type of Change
Description
Additional Changes
Motivation and Context
How did you test it?
Connector:
adyen_ukNote: The
SofortTest Cases are removed in PR #7099 after being deprecated byadyenconnector.Connector:
bluesnapConnector:
cybersourceBefore
After
Connector:
nmiBefore
After
Connector:
paypalConnector:
stripeFailing too inconsistently. Different number of test cases are failing. It is not even the same test cases each time it fails.
Connector:
trustpayBefore
After
Checklist
cargo +nightly fmt --allcargo clippy