Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't find Preact out of the box #17

Closed
unicodeveloper opened this issue Jun 1, 2017 · 8 comments
Closed

Can't find Preact out of the box #17

unicodeveloper opened this issue Jun 1, 2017 · 8 comments

Comments

@unicodeveloper
Copy link

unicodeveloper commented Jun 1, 2017

screen shot 2017-06-01 at 5 24 05 pm

Do i need to install preact and preact-compat after installation via this script?

Any reason why preact and preact-compat doesn't get installed automatically @just-boris

@just-boris
Copy link
Owner

Yes, you will need to install preact on your own.
Unfortunately, the react and react-dom dependencies are hard-coded as a part of create-react-app command, so it is not possible to modify it via --scripts-version option. I will update the readme with that information.

@just-boris just-boris reopened this Jun 1, 2017
@just-boris
Copy link
Owner

Sorry, tested this again, everything works fine for me. I have got preact installed without additional steps.

How did you create the app? In the Readme, we have the following command

create-react-app my-app --scripts-version @just-boris/preact-scripts
cd my-app/
npm start

Did it work for you?

@unicodeveloper
Copy link
Author

And you didn't get the failed to compile error?

@just-boris
Copy link
Owner

I have got spinning React logo, as it was expected for demo page.

@sconnelley
Copy link

I can verify the behavior @unicodeveloper experienced. Works fine after manually install preact and preact-compact. I am using create-react-app at version 1.3.1 if that's helpful.

@unicodeveloper
Copy link
Author

unicodeveloper commented Jun 3, 2017 via email

@unicodeveloper
Copy link
Author

unicodeveloper commented Jun 3, 2017 via email

@just-boris
Copy link
Owner

Confirm the problem. I could not reproduce it before because I had and older version of create-react-command.

As the only possible solution, I recommend you to run npm install or yarn, depending what you are using, before starting the server. I will add this as a part of setup steps in README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants