Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@angular-builders/custom-webpack to support Angular 16 #1355

Closed
CarlosTorrecillas opened this issue May 4, 2023 · 13 comments
Closed

@angular-builders/custom-webpack to support Angular 16 #1355

CarlosTorrecillas opened this issue May 4, 2023 · 13 comments

Comments

@CarlosTorrecillas
Copy link

Is your feature request related to a problem? Please describe.
@angular-builders/custom-webpack compatible with Angular 16

Describe the solution you'd like
@angular-builders/custom-webpack to be able to be installed on an Angular 16 project

Describe alternatives you've considered
I haven't found any yet

Additional context
Running the migration of one of my projects from Angular 15 to Angular 16 and leaving @angular-builders/custom-webpack on the latest version, produces the following error:

This version of CLI is only compatible with Angular versions ^15.0.0, but Angular version 16.0.0 was found instead. which stops the process during my build

@phihochzwei
Copy link

+1

For us this is currently a showstopper on updating to NG16, which is quite sad since the Hydration Feature is a game changer

@CarlosTorrecillas
Copy link
Author

Me too @phihochzwei , hopefully a new version of the package gets released soon. Fingers crossed!!

@just-jeb
Copy link
Owner

just-jeb commented May 4, 2023

Hopefully next week guys, a bit of patience 🙂.

@phihochzwei
Copy link

Hopefully next week guys, a bit of patience 🙂.

Well, I guess, ever Angular developer is currently like

7kkza6

yutamago added a commit to yutamago/ami that referenced this issue May 6, 2023
yutamago added a commit to yutamago/ami that referenced this issue May 7, 2023
@simeyla
Copy link

simeyla commented May 16, 2023

Can anyone comment on the long term viability / prospects for @angular-builders/custom-webpack ?
Is it likely to be obsolete / incompatible with any upcoming Angular integrations of vite or esbuild?

Personally I use it for:

  • retry plugin (webpack-retry-chunk-load-plugin)
  • reduce moment js size (moment-locales-webpack-plugin)
  • custom plugin to write out the webpack manifest (to preload JS bundles)

I'm asking more from a technical standpoint rather than a willingness-to-maintain standpoint.

@polhek
Copy link

polhek commented May 17, 2023

@simeyla in our application we use it as we are migrating from angularJS to angular.

@just-jeb
Copy link
Owner

@simeyla as long as Angular supports Webpack this builder will be maintained and probably relevant.
Native Angular esbuild builder doesn't support extension interface at the moment so there is nothing we (or as a matter of fact anyone else) can do about it. If they'll open it for extensions we can create a new builder (like custom-esbuild) but it will certainly not be implemented as part of custom-webpack builder.
Hope it answers your question. Related issue: #1288

@emmanuel-musau
Copy link

I am waiting for angular-builders/custom-webpack to support angular 16 eagerly, I have an angular project that is stuck because I need do enable some experiments.
Any update on the progress would be much appreciated.

@just-jeb
Copy link
Owner

@Emmanuel-FSE This is the PR to track: #1357
I'm waiting on final approval from @arturovt, who's been working on this PR, in order to merge it.

@md13381
Copy link

md13381 commented May 17, 2023

@Emmanuel-FSE This is the PR to track: #1357 I'm waiting on final approval from @arturovt, who's been working on this PR, in order to merge it.

Is he not waiting on you to review it for merge? Its been requested for review for the last couple of days

@just-jeb
Copy link
Owner

@md13381 yeah haha. We've been talking internally, don't worry 😁 It's almost done.

@just-jeb
Copy link
Owner

You're welcome to try the new version under the @next tag. We'll give it a few days in beta and then graduate to stable.
image

@just-jeb
Copy link
Owner

Stable version is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants