Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve initial instructions to use current clone etc #8

Merged
merged 6 commits into from
Mar 19, 2024

Conversation

rfay
Copy link
Contributor

@rfay rfay commented Mar 2, 2024

We did a LONG support help in Drupal #ddev Slack with quite a number of stumbles on this.

  • Use current git clone technique (it may need --branch as well) (https://www.drupal.org/node/3060/git-instructions/11.x/nonmaintainer)
  • Use a directory name and project name that is more suited, like core-dev
  • Current stable DDEV does not detect drupal11 (which is HEAD) so ddev config --auto gets the php project type.
  • Don't use && for setup because people won't pay attention to failures.

Obviously the --project-type=drupal10 will want to be updated when DDEV has support for drupal11 later this year. It will probably be --project-type=drupal then.

@rpkoller
Copy link

rpkoller commented Mar 3, 2024

one suggestion instead of ddev config --auto use ddev config --omit-containers=db, since the add-on is using sqlite and not any of the database containers ddev is providing. save a little bit of diskspace and makes it clear that another db than mysql, mariadb or postgres is used.

@rfay
Copy link
Contributor Author

rfay commented Mar 3, 2024

This PR already stops using --auto and instead gives specific project type. But I see no harm in --omit-containers=db.

Note that running db container doesn't use up any disk space, but does use some memory.

@rpkoller
Copy link

rpkoller commented Mar 3, 2024

oh it was too late when i was reading the files changed section this morning. you are right. sorry. and about the db container. if i do a docker image ls there is one db container for the project that is using the ddev-drupal-core-dev addon:

ddev/ddev-dbserver-mariadb-10.4    20240213_mariadb_1011_default-drupalcore-built   d5622e591ce3   2 days ago     649MB

so some diskspace is used for that?

@rfay
Copy link
Contributor Author

rfay commented Mar 3, 2024

There has to be, but I think you'll find it's trivial.

Copy link
Owner

@justafish justafish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I'm not sure why the directory name change is more suitable, but welcome a follow up if I've missed something there 😄

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@justafish justafish merged commit 1e6d515 into justafish:main Mar 19, 2024
@rfay rfay deleted the patch-1 branch March 19, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants