Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching GitHub Action to use Zulu Builds. #138

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

carldea
Copy link
Contributor

@carldea carldea commented Sep 27, 2021

What this PR does / why we need it:

The AdoptOpenJDK has been discontinued since July 2021. When using Zulu you get all the latest updated (TCK Tested) builds for all versions of OpenJDK including archived builds (major fixed versions). Replacing the build distro to Zulu is nice because some environments use a major fixed version such as Java 8.0.192, that many vendor builds don't support.
This PR is backwards compatible since GitHub Actions setup-java@v1 originally used Azul Zulu.

The AdoptOpenJDK has been discontinued since July 2021. When using Zulu you get all the latest updated (TCK Tested) builds for all versions of OpenJDK included archived major fixed versions.
The AdoptOpenJDK has been discontinued since July 2021. When using Zulu you get all the latest updated (TCK Tested) builds for all versions of OpenJDK included archived major fixed versions.
@zhangyd-c zhangyd-c merged commit 12edff8 into justauth:master Sep 29, 2021
@carldea
Copy link
Contributor Author

carldea commented Sep 30, 2021

Thank you. Glad to have helped contribute to this project.

@kang8
Copy link
Contributor

kang8 commented Sep 30, 2021

@carldea Can you provide some links to show the fact that adopt has been discontinued?

@geertjanw
Copy link

https://blog.adoptopenjdk.net/2021/03/transition-to-eclipse-an-update/

@carldea
Copy link
Contributor Author

carldea commented Sep 30, 2021

Another thing to note (for good measure) is adding a major fixed release version such as Java 8.0.192. This is often a very good practice, when your software is used by vendors and/or customers relying on earlier releases (LTS fixed versions).
What's nice about this practice is the following example:

  • Build/Test Java 8.0.192 passes (green)
  • Build/Test Java 8 (latest) fails (red)

This indicates that it is not your code but the latest Java build that broke the build/test.

If you prefer, I will can create another PR to add Java 8.0.192 as an additional version to test.
I would use something like the following:

strategy:
      matrix:
        os: [ ubuntu-latest ]
        java-version: [ 8, 8.0.192 ]

谢谢你

Carl
谢力游

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants