This repository has been archived by the owner on Jul 7, 2022. It is now read-only.
Fully async #30
Merged
Fully async #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martincostello
approved these changes
Nov 8, 2018
shaynevanasperen
approved these changes
Nov 8, 2018
|
Before I forget, before publishing this repo will need a major version bump as adding strong naming is a breaking change. |
|
So at the moment, the last version was 2.0.0-beta-51, the previous commit drops the beta and makes in the final release, but we never pushed it to nuget. So I could add the beta back now, just in case there are any changes needed before making it 2.0.0. While we are in beta we are still ok to make braking changes according with SemVer. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes JustBehave no longer block on async code, this should allow consumers (JustSaying for example) to have non-blocking startup code, for teardown you'll need to rename
PostAssertTeardown->PostAssertTeardownAsyncand return aTaskwhen using the async base class.This also adds strong naming. My hope is for this to be a good candidate for release (after a beta), fixing the outstanding major issues.