This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
Remove code generation for TweakManager #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertodebortoli
force-pushed
the
remove-code-generation-for-tweak-manager
branch
from
0052950 to
e2e6035
Compare
agroGandhi
approved these changes
May 7, 2021
| @@ -29,4 +30,36 @@ class AppDelegate: UIResponder, UIApplicationDelegate { | |||
| window?.rootViewController?.present(alertController, animated: true, completion: nil) | |||
| } | |||
| } | |||
|
|
|||
| func makeTweakManager() -> TweakManager { | |||
There was a problem hiding this comment.
nit: could make this var tweakManager: TweakManager
There was a problem hiding this comment.
So it would have to be a lazy var instead of computed property or we would re-create the manager each time (I know, we currently call it only once). Is it really worth it?
| tweakProviders.append(\(tweakProviderName)) | ||
| """ | ||
| generatedString.append(tweakProviderAllocation) | ||
| private func tweakManagerCodeBlock() -> String { |
There was a problem hiding this comment.
nit: same here could use var here if you fancied
There was a problem hiding this comment.
The rest of the file has functions, feels better to keep them all as functions IMHO. The fact that there are no parameters here is less important than having overall consistency in this file I would say.
gigisommo
approved these changes
May 7, 2021
|
Agree with @agroGandhi to proceed with merging this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We realised that
TweakAccessorGeneratorwas trying to be too smart in generating the code for theTweakManager.When using the configuration with
usePropertyWrappers = trueit was generating a singleton which is known to be a bad pattern, but we initially thought was somehow good enough for small apps. Needless to say, we do regret such decision. We have now agreed that we don't want to promote such usage and we also can't use it internally in the Just Eat app.Even without the singleton, the generated accessor wasn't allowing dependency injection in the tweak providers setup code, which is also a limitation we can avoid having. This PR now leaves the user free to setup a
TweakManagerand inject it into the generated accessor.