-
Notifications
You must be signed in to change notification settings - Fork 30
Added a decryption closure and value #62
Added a decryption closure and value #62
Conversation
The PR description mentions
but the TweakProvider protocol has been modified and since it's public, the addition of a new property technically makes the new version of JustLog not backwards compatible and clients will have to update any implementation of custom Different story for the I also noticed that the demo app has 2 tweak providers that have been removed from the target (and therefore are not compiled) and still inherit from |
@albertodebortoli @dchakarov I've updated it with Alberto's feedback. If all is good after Dimi's review, you can merge it (I don't think I have the permission myself) |
@albertodebortoli @dchakarov Added a few more tests. Just to make sure the implementations of |
Description
decryptionClosure
variable to theTweakProvider
protocoldecryptedValue
let
toTweak
mutatedCopy
function toTweak
to be able to duplicate it and set the decrypted valueMotivation and Context
Copied from the design doc:
A closure property
decryptionClosure
is added toTweakProvider
with the signatureA new property
decryptedValue
is added toTweak
This will either return the decrypted
TweakValue
(passed throughdecryptionClosure
) or justthe existing
value
if nodecryptionClosure
is specified.Usage would then look like this
How Has This Been Tested?
Added a unit test that sets the tweak value to a base64 encoded string. And set a
decryptionClosure
that decodes the base64 encoded string, which is then checkedTypes of changes
Checklist: