Fold the SimpleObjectPool into ConnectedSocketPool #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fold the `SimpleObjectPool` into `ConnectedSocketPool` as that is the only place that it used.
| private readonly SimpleObjectPool<Socket> _pool; | ||
| private readonly ConcurrentBag<Socket> _pool = new ConcurrentBag<Socket>(); | ||
|
|
||
| public IPEndPoint IpEndPoint { get; } | ||
|
|
||
| public ConnectedSocketPool(IPEndPoint ipEndPoint) |
There was a problem hiding this comment.
Maybe we should make count a parameter and have the caller specify the value? (which would happen to be Environment.ProcessorCount)
| { | ||
| var socket = UdpTransport.CreateSocket(); | ||
| if (socket == null) |
There was a problem hiding this comment.
UdpTransport.CreateSocket() never returns null.
- remove redundant null check - hoist the `Environment.ProcessorCount` up to `PooledUdpTransport`
martincostello
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarise the changes this Pull Request makes.
Fold the
SimpleObjectPoolintoConnectedSocketPool, as that is the only place that it used.Follow on from #109
Todo in later PRs:
ConnectedSocketPoolis used inPooledUdpTransport.We also have:
UdpTransport- the unpooled version, suggest that that one is deleted in4.0.0IpTransportwhich is useful for AWS Lambdas, but could also benefit from pooling?ConnectedSocketPoolcould also be extended to have option to store the IP sockets if need be?Please include a reference to a GitHub issue if appropriate.