-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync fixes to release/3xx #124
Merged
martincostello
merged 14 commits into
justeattakeaway:release/3xx
from
martincostello:v322
Oct 7, 2018
Merged
Sync fixes to release/3xx #124
martincostello
merged 14 commits into
justeattakeaway:release/3xx
from
martincostello:v322
Oct 7, 2018
+298
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a failing unit test for DnsLookupIpEndpointSource using localhost.
When resolving the hostname for "localhost", prefer IPv4 to IPv6 addresses, as statsd does not listen on IPv6 by default.
Add an integration test that sends metrics to a real statsd instance running locally in AppVeyor or Travis and verifies that the values sent to the server are correct by using the admin endpoint.
"Fix" AppVeyor build by routing std-err usage during git clone into /dev/nul (see https://help.appveyor.com/discussions/problems/555-accessing-another-repository-during-a-build).
Fix typo in file name when starting statsd in Travis.
Try using cmd instead of ps to just do a simple clone in AppVeyor.
Try changing the git clone path as seen in others' YAML files.
Update the version to 3.2.2 so we're ready to do another release if we need to.
Update to the latest version of the .NET Core SDK.
Configure Travis to build the release/3xx branch.
AnthonySteele
approved these changes
Oct 7, 2018
Add failing unit tests for sending multiple counters at once when buffers are not in use.
Fix malformed metrics being sent to statsd when buffers are not used, which caused stats to be dropped, due to incorrect concatenation being used. Add optimisations to not send empty strings to statsd. Add null check for buckets array.
Tidy-up formatting slightly.
Fix more invalid statsd metrics in tests for if/when they make their way to a real statsd instance.
Also need to port 1e37064 back to |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the fix from #121 and the tests from #122 into the
release/3xx
branch via cherry-picking so that if we need to do another3.x.x
release, we've got some safe changes from master in that branch.Also bumps the version in this branch to
3.2.2
.Replaces #123.