Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync fixes to release/3xx #124

Merged
merged 14 commits into from
Oct 7, 2018
Merged

Sync fixes to release/3xx #124

merged 14 commits into from
Oct 7, 2018

Conversation

martincostello
Copy link
Member

Merge the fix from #121 and the tests from #122 into the release/3xx branch via cherry-picking so that if we need to do another 3.x.x release, we've got some safe changes from master in that branch.

Also bumps the version in this branch to 3.2.2.

Replaces #123.

Add a failing unit test for DnsLookupIpEndpointSource using localhost.
When resolving the hostname for "localhost", prefer IPv4 to IPv6 addresses, as statsd does not listen on IPv6 by default.
Add an integration test that sends metrics to a real statsd instance running locally in AppVeyor or Travis and verifies that the values sent to the server are correct by using the admin endpoint.
"Fix" AppVeyor build by routing std-err usage during git clone into /dev/nul (see https://help.appveyor.com/discussions/problems/555-accessing-another-repository-during-a-build).
Fix typo in file name when starting statsd in Travis.
Try using cmd instead of ps to just do a simple clone in AppVeyor.
Try changing the git clone path as seen in others' YAML files.
Update the version to 3.2.2 so we're ready to do another release if we need to.
@martincostello martincostello requested a review from a team as a code owner October 7, 2018 07:39
Update to the latest version of the .NET Core SDK.
Configure Travis to build the release/3xx branch.
@martincostello
Copy link
Member Author

Will do a PR to merge b7eef3a and dfe1972 back to master once this is merged.

Add failing unit tests for sending multiple counters at once when buffers are not in use.
Fix malformed metrics being sent to statsd when buffers are not used, which caused stats to be dropped, due to incorrect concatenation being used.
Add optimisations to not send empty strings to statsd.
Add null check for buckets array.
Tidy-up formatting slightly.
Fix more invalid statsd metrics in tests for if/when they make their way to a real statsd instance.
@martincostello
Copy link
Member Author

Also need to port 1e37064 back to master.

@martincostello martincostello added this to the v3.2.2 milestone Oct 7, 2018
@martincostello martincostello merged commit f478809 into justeattakeaway:release/3xx Oct 7, 2018
@martincostello martincostello deleted the v322 branch October 7, 2018 16:51
@martincostello martincostello mentioned this pull request Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants