Add static analyzers #126
Merged
Add static analyzers #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add source analyzers that could find issues with the code at build time through static analysis.
Disable warnings that do not apply to tests or benchmarks.
Remove redundant methods that are no longer used since the interface was changed to remove a number of methods.
Make methods and class static where instance members are not used.
Fix warnings in the integration tests related to string comparisons and case sensitivity.
Fix unused instance warnings by using Assert.Throws() that takes a Func<T> instead of an Action.
Fix warnings about unused members/parameters.
Fix warning for the way IDisposable is implemented by making the internal timer type sealed.
Fix exception being thrown with the wrong type and parameter name.
Use Array.Empty<T>() in target frameworks that support it.
Specify ConfigureAwait(false) when awaiting the tasks in the async timer extensions.
| } | ||
|
|
||
| [Fact] | ||
| public static void InvalidSocketProtocolThrowsInConstructor() | ||
| { | ||
| Should.Throw<ArgumentOutOfRangeException>( | ||
| () => new SocketTransport(LocalStatsEndpoint(), (SocketProtocol)42)); | ||
| SocketProtocol socketProtocol = (SocketProtocol)42; |
There was a problem hiding this comment.
Can you use var here? and name it invalidSocketProtocol ?
There was a problem hiding this comment.
var is fine, but I prefer to have the variable and argument names match for simple tests scenarios like this. Happy to change it if we really want the name like that though.
AnthonySteele
approved these changes
Oct 7, 2018
AnthonySteele
pushed a commit
to AnthonySteele/NuKeeper
that referenced
this pull request
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Roslyn code analyzers (a bit like FxCop of old) that run at build time. It also fixes various issues identified by them including:
IStatsDPublisherover time.DisposableTimerclass sealed.Array.Empty<T>()to save an allocation in target frameworks that support it.ConfigureAwait(false)when awaiting tasks.