Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments review #156

Merged
merged 9 commits into from
Dec 13, 2018
Merged

Comments review #156

merged 9 commits into from
Dec 13, 2018

Conversation

martincostello
Copy link
Member

  • Update XML documentation for the 4.0.0 release.
  • Make StatsDUtf8Formatter sealed.
  • Add parameter validation to CachedEndpointSource.
  • Rename constructor argument of DisposableTimer to match parameter names at call sites.

Resolves #130.

Make the internal class StatsDUtf8Formatter sealed.
Fix grammar in class comments.
Validate that the cache duration is a positive TimeSpan to flush out configuration mistakes.
Add XML documentation for exceptions to TimerExtensions' methods.
Rename constructor argument to match parameter names at call sites.
Update the XML comments for the SocketProtocol enumeration.
@martincostello martincostello added this to the v4.0.0 milestone Dec 13, 2018
@martincostello martincostello requested a review from a team as a code owner December 13, 2018 14:13
Spell "enumeration" correctly.
Rename StatName to Bucket.
Check that actions and functions are not null and throw if they are.
Change the /// comment as suggested.
@martincostello martincostello merged commit 60521fb into justeattakeaway:master Dec 13, 2018
@martincostello martincostello deleted the Comments-Review branch December 13, 2018 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants