Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug #599 - Update documentation to reflect the correct signature of the Timing() method #600

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

mtn-boblloyd
Copy link
Contributor

Summarise the changes this Pull Request makes.
Updated the documentation for the Timing method to be correct, as it was incorrect before.

Please include a reference to a GitHub issue if appropriate.
#599

@mtn-boblloyd mtn-boblloyd requested a review from a team as a code owner January 8, 2024 15:00
README.md Outdated Show resolved Hide resolved
@martincostello martincostello added this to the v5.0.1 milestone Jan 8, 2024
@martincostello martincostello linked an issue Jan 8, 2024 that may be closed by this pull request
@martincostello martincostello enabled auto-merge (squash) January 8, 2024 15:22
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3623a67) 83.77% compared to head (e9384c4) 83.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
- Coverage   83.77%   83.48%   -0.30%     
==========================================
  Files          28       28              
  Lines         672      672              
  Branches      151      151              
==========================================
- Hits          563      561       -2     
- Misses         67       70       +3     
+ Partials       42       41       -1     
Flag Coverage Δ
linux 82.73% <ø> (-0.45%) ⬇️
macos 83.18% <ø> (-0.30%) ⬇️
windows 82.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 615728e into justeattakeaway:main Jan 8, 2024
12 of 13 checks passed
@martincostello
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for Timing feature is incorrect
2 participants