Migrate publish integration test #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustSaying.IntegrationTests/Fluent/Publishing/WhenAMessageIsPublishedToAQueue.cs
Show resolved
Hide resolved
| services, | ||
| async (publisher, listener, cancellationToken) => | ||
| { | ||
| listener.Start(cancellationToken); |
Migrate an existing test to the new builder API.
Delete a comment that does not apply to the type.
Fix validation being run before the queue name was set. Fix incorrect XML comment.
Add convenience methods for setting queue and topic names. Add missing XML documentation for type parameters.
Improve messaging if a publisher is not configured.
Refactor integration test to reduce duplication.
Remove validation from the builders as because they might compose, they might not become valid until later and thus block activation.
Add an extension method to the Microsoft DI extensions that wraps usage of IMessageBusConfigurationContributor for a delegate.
Migrate more integration tests for publishing to the new fluent API.
Refactor integration test to simplify it a bit.
Migrate two more tests to the new builder API.
Move two subscription tests to the right namespace for that, rather than for publishing.
Remove base class for test that is no longer used.
Migrate the test for throttled receipt to the new builder pattern.
AnthonySteele
approved these changes
Dec 18, 2018
|
I'll merge this for now with no changes, but bear the comment in mind. I imagine the tests will iterate as JustBehave is slowly removed as different bits of duplication and repetition get flushed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the first existing integration test to the new builder API (#431), and fixes a few bugs and other improvements made while migrating it.
IMessageBusConfigurationContributor.Relates to #380.