-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pie-thumbnail): DSW-2615 add the aspect ratio prop #2184
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 9068dfa The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
/snapit |
Starting a new snapshot build. You can view the logs here. |
@raoufswe Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/pie-thumbnail@0.0.0-snapshot-release-20250203094341 --mode=update-lockfile yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20250203094341 --mode=update-lockfile Then finally: yarn install |
edb20fd
to
101582d
Compare
/snapit |
Starting a new snapshot build. You can view the logs here. |
@raoufswe Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/pie-thumbnail@0.0.0-snapshot-release-20250204164145 --mode=update-lockfile yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20250204164145 --mode=update-lockfile Then finally: yarn install |
/snapit |
Starting a new snapshot build. You can view the logs here. |
@raoufswe Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/pie-thumbnail@0.0.0-snapshot-release-20250204215440 --mode=update-lockfile yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20250204215440 --mode=update-lockfile Then finally: yarn install |
Describe your changes (can list changeset entries if preferable)
Author Checklist (complete before requesting a review, do not delete any)
PIE Storybook
/PIE Docs
PR preview./test-aperture
command.Not-applicable Checklist items
Please move any Author checklist items that do not apply to this pull request here.
Testing
How do I test my changes?
Reviewer checklists (complete before approving)
Mark items as
[-] N/A
if not applicable.Reviewer 1
PIE Storybook
/PIE Docs
PR preview.Reviewer 2
PIE Storybook
/PIE Docs
PR preview.