Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-thumbnail): DSW-2615 add the aspect ratio prop #2184

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

raoufswe
Copy link
Member

@raoufswe raoufswe commented Jan 31, 2025

Describe your changes (can list changeset entries if preferable)

  • Adds the aspect ratio prop to the component

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.


Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@raoufswe raoufswe requested review from a team as code owners January 31, 2025 12:30
Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: 9068dfa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@justeattakeaway/pie-thumbnail Minor
pie-storybook Minor
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pie-design-system-bot
Copy link
Contributor

pie-design-system-bot commented Jan 31, 2025




Fails
🚫 You have unchecked checklist items outside the "Not-applicable Checklist items" section.

Please ensure all unchecked checkboxes are moved to the appropriate section.

🚫 You have unchecked checklist items in Reviewer 1's section.

Please ensure all items are addressed before approval.

🚫 You have unchecked checklist items in Reviewer 2's section.

Please ensure all items are addressed before approval.

Generated by 🚫 dangerJS against 9068dfa

@github-actions github-actions bot temporarily deployed to storybook-pr-2184 January 31, 2025 12:36 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2184 January 31, 2025 12:36 Inactive
@raoufswe
Copy link
Member Author

raoufswe commented Feb 3, 2025

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@raoufswe Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-thumbnail@0.0.0-snapshot-release-20250203094341 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20250203094341 --mode=update-lockfile

Then finally:

yarn install

Base automatically changed from dsw-2582-add-size-prop to main February 3, 2025 11:31
@raoufswe raoufswe force-pushed the dsw-2615-aspect-ratio branch from edb20fd to 101582d Compare February 3, 2025 12:19
@github-actions github-actions bot temporarily deployed to storybook-pr-2184 February 3, 2025 12:24 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2184 February 3, 2025 12:24 Inactive
@raoufswe raoufswe self-assigned this Feb 3, 2025
@github-actions github-actions bot temporarily deployed to storybook-pr-2184 February 3, 2025 15:19 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2184 February 3, 2025 15:19 Inactive
@github-actions github-actions bot temporarily deployed to storybook-pr-2184 February 4, 2025 15:57 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2184 February 4, 2025 15:58 Inactive
@raoufswe
Copy link
Member Author

raoufswe commented Feb 4, 2025

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@raoufswe Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-thumbnail@0.0.0-snapshot-release-20250204164145 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20250204164145 --mode=update-lockfile

Then finally:

yarn install

@github-actions github-actions bot added the tools label Feb 4, 2025
@github-actions github-actions bot temporarily deployed to storybook-pr-2184 February 4, 2025 16:57 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2184 February 4, 2025 16:57 Inactive
@github-actions github-actions bot removed the tools label Feb 4, 2025
@github-actions github-actions bot temporarily deployed to storybook-pr-2184 February 4, 2025 17:11 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2184 February 4, 2025 17:11 Inactive
@github-actions github-actions bot temporarily deployed to storybook-pr-2184 February 4, 2025 21:24 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2184 February 4, 2025 21:24 Inactive
@github-actions github-actions bot temporarily deployed to storybook-pr-2184 February 4, 2025 21:46 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2184 February 4, 2025 21:46 Inactive
@raoufswe
Copy link
Member Author

raoufswe commented Feb 4, 2025

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@raoufswe Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-thumbnail@0.0.0-snapshot-release-20250204215440 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20250204215440 --mode=update-lockfile

Then finally:

yarn install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants