Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding Error ST3 and ST4 #40

Closed
JokerMartini opened this issue Sep 29, 2021 · 6 comments
Closed

Encoding Error ST3 and ST4 #40

JokerMartini opened this issue Sep 29, 2021 · 6 comments
Assignees
Labels

Comments

@JokerMartini
Copy link

For whatever reason in both versions of ST3 and ST4 whenever i try to send a command to maya using the Send File command i get this error:

#   File "<string>", line 24, in <module>
# TypeError: 'encoding' is an invalid keyword argument for this function

However if i select all the text and 'send selected text' instead of 'send file' i don't get the error. What is happening here and why? How can this be fixed?

@JokerMartini
Copy link
Author

Was there a recent update regarding encoding of some sort. We can no longer send 'file's to maya. Only selected text which is quite annoying. I'm sure I'm just missing something simple here.

@JokerMartini
Copy link
Author

I added a fix to your commit that breaks sublime text for maya

else:
	try:
		with open({fp!r}) as _fp:
			_code = compile(_fp.read(), {fp!r}, 'exec')
			exec(_code, namespace, namespace)
	except:
		with open({fp!r}, encoding='utf-8') as _fp:
			_code = compile(_fp.read(), {fp!r}, 'exec')
			exec(_code, namespace, namespace)	

@justinfx
Copy link
Owner

@JokerMartini can you give the master branch a test again?

@JokerMartini
Copy link
Author

Sure lll try it now

@JokerMartini
Copy link
Author

All is fixed and working now. Thanks Justin!

@justinfx justinfx added the bug label Sep 29, 2021
@justinfx
Copy link
Owner

Thanks! I've released v3.1.2
https://github.com/justinfx/MayaSublime/releases/tag/3.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants