asdf #2
Merged
asdf #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a call to kubectl fails to parse the output, we'll return a parsing failure directly to the user. Instead, return a failed job with the error message and let the caller handle the exception as it would any other failed job.
Pods are currently set as having a cluster relationship; this means that we create a cluster (and associated relationship to the pod) for every pod in a kubernetes deployment. This is not necessary, and doesn't match the definition of cluster used by other providers. These clusters and relationships are also not used when we construct the server group model for a Kubernetes application; we end up ignoring any cluster that does not map to a server group (which pods do not). This change will significantly improve the efficiency of both the caching logic, and the logic to return server groups for kubernetes (which now will not need to process each pod individually).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prefer small, well tested pull requests.
Please refer to Contributing to Spinnaker.
When filling out a pull request, please consider the following:
Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.