Skip to content

Commit

Permalink
Merge pull request kubernetes-sigs#238 from mengqiy/disable_metrics_b…
Browse files Browse the repository at this point in the history
…y_default

✨ change metrics default to off
  • Loading branch information
k8s-ci-robot committed Dec 5, 2018
2 parents 97b16f5 + 59aab21 commit ab27d83
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion pkg/metrics/listener.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ import (

// DefaultBindAddress sets the default bind address for the metrics
// listener
var DefaultBindAddress = ":8080"
// The metrics is off by default.
// TODO: Flip the default by changing DefaultBindAddress back to ":8080" in the v0.2.0.
var DefaultBindAddress = "0"

// NewListener creates a new TCP listener bound to the given address.
func NewListener(addr string) (net.Listener, error) {
Expand Down

0 comments on commit ab27d83

Please sign in to comment.