Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Vue 3 #26

Merged
merged 7 commits into from
Jul 7, 2021
Merged

Feat: Vue 3 #26

merged 7 commits into from
Jul 7, 2021

Conversation

domgew
Copy link
Contributor

@domgew domgew commented Jun 30, 2021

Closes #25
Closes #24

@justintaddei
Copy link
Owner

At work. I will review soon.

@justintaddei justintaddei self-requested a review June 30, 2021 16:01
@justintaddei justintaddei self-assigned this Jun 30, 2021
@justintaddei justintaddei added the enhancement New feature or request label Jun 30, 2021
@justintaddei
Copy link
Owner

Look great! I would, however, love to maintain backward compatibility with Vue2 if it's possible. I wasn't sure how to write this in a backward-compatible way myself, which is why I haven't worked on this yet. Do you think it's possible to implement it in such a way that it can support both Vue2 and Vue3? If not, we can just move forward from here and maintain a separate branch for Vue2 support as long as needed.

Thank you for work on this!

@justintaddei justintaddei added this to the $.0.0 milestone Jul 1, 2021
@domgew
Copy link
Contributor Author

domgew commented Jul 1, 2021

Unfortunately I don't think this is possible at the moment. Otherwise big libraries probably would not have a separate branch/tag for Vue 3 (@next).
But there is a migration build of Vue which might be worth a look. Nuxt however is on the limitations list.

Edit: There is a library (vue-demi) which combines Vue 2 and Vue 3. But it would need some fiddling with the router and might not be as clean.

@domgew
Copy link
Contributor Author

domgew commented Jul 3, 2021

@justintaddei
I have created a backwards compatible version which seems to work with Vue 2 and Vue 3 but the code is less elegant and the package.json is not as clean as one might wish. Nevertheless, let me know whether you want to go with this approach then I'll merge the compatibility into this pull request. The other way would be to have a separate branch for Vue 3 (e.g. next) or make a breaking version change and not support Vue 2 with future updates.

@justintaddei
Copy link
Owner

Definitely like this approach better than splitting the repo. It looks great to me but I've only been able to view this on my phone. I'll take a more in-depth look later today just to double check. When you can, please merge this into the PR!

@domgew
Copy link
Contributor Author

domgew commented Jul 4, 2021

I've merged the Vue 2 compatible version and also taken the liberty to update the documentation (README.md and CHANGELOG.md). The latter under the assumption that it'll be merged tomorrow (July 5th). Furthermore, I've decreased the version number to 3.1.0 as there is no breaking change anymore.

Copy link
Owner

@justintaddei justintaddei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! I reverted the version number to 3.0.3 because it will be bumped and tagged automatically when I publish the update.

I also credited you for Vue 3 support in the README. Let me know if that is okay. I'll wait to publish until I hear from you.

@domgew
Copy link
Contributor Author

domgew commented Jul 7, 2021

I don't mind and I'm looking forward to using the official package instead of a git ref for my Vue 3 projects.

@justintaddei justintaddei merged commit dfee224 into justintaddei:master Jul 7, 2021
@justintaddei
Copy link
Owner

I'm looking forward to using the official package instead of a git ref for my Vue 3 projects.

Thank you for all of your work on this!

v3.1.0 has just been published on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue3?? index.js:239 Uncaught TypeError: Cannot set property '$illusory' of undefined
2 participants