-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Vue 3 #26
Feat: Vue 3 #26
Conversation
At work. I will review soon. |
Look great! I would, however, love to maintain backward compatibility with Vue2 if it's possible. I wasn't sure how to write this in a backward-compatible way myself, which is why I haven't worked on this yet. Do you think it's possible to implement it in such a way that it can support both Vue2 and Vue3? If not, we can just move forward from here and maintain a separate branch for Vue2 support as long as needed. Thank you for work on this! |
Unfortunately I don't think this is possible at the moment. Otherwise big libraries probably would not have a separate branch/tag for Vue 3 ( Edit: There is a library (vue-demi) which combines Vue 2 and Vue 3. But it would need some fiddling with the router and might not be as clean. |
@justintaddei |
Definitely like this approach better than splitting the repo. It looks great to me but I've only been able to view this on my phone. I'll take a more in-depth look later today just to double check. When you can, please merge this into the PR! |
I've merged the Vue 2 compatible version and also taken the liberty to update the documentation (README.md and CHANGELOG.md). The latter under the assumption that it'll be merged tomorrow (July 5th). Furthermore, I've decreased the version number to 3.1.0 as there is no breaking change anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good! I reverted the version number to 3.0.3 because it will be bumped and tagged automatically when I publish the update.
I also credited you for Vue 3 support in the README. Let me know if that is okay. I'll wait to publish until I hear from you.
I don't mind and I'm looking forward to using the official package instead of a git ref for my Vue 3 projects. |
Thank you for all of your work on this! v3.1.0 has just been published on npm. |
Closes #25
Closes #24