Skip to content

Commit

Permalink
sca: check if runtime dependencies are vendored
Browse files Browse the repository at this point in the history
This fixes and issue with 288fb15 that
too broadly added dependencies on vendored libraries.

Libreoffice for example picked up a dep to an internal library without
the corresponding provides.
  • Loading branch information
justinvreeland committed Oct 7, 2024
1 parent 283c45e commit b01b6a6
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions pkg/sca/sca.go
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,9 @@ func generateSharedObjectNameDeps(ctx context.Context, hdl SCAHandle, generated

for _, soname := range sonames {
log.Infof(" found soname %s for %s", soname, path)

generated.Runtime = append(generated.Runtime, fmt.Sprintf("so:%s", soname))
if isInDir(path, libDirs) {
generated.Runtime = append(generated.Runtime, fmt.Sprintf("so:%s", soname))
}
}
}

Expand Down

0 comments on commit b01b6a6

Please sign in to comment.