Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make --inputglob and --outputcheck work on their own #216

Merged
merged 1 commit into from
May 12, 2024

Conversation

deeptoaster
Copy link
Contributor

@deeptoaster deeptoaster commented Apr 6, 2024

A command like tsc-alias -p tsconfig.json --inputglob js --outputcheck js currently fatals with

            fileExtensions.inputGlob = options.fileExtensions.inputGlob;
                                     ^

TypeError: Cannot set properties of undefined (setting 'inputGlob')

because the removed lines leave fileExtensions unset when used with a config that doesn't contain that field. (A workaround is to put a dummy "tsc-alias": { "fileExtensions": {} } in tsconfig.json.)

@deeptoaster deeptoaster changed the title fix: make --inputglob and --outputcheck work on their own fix: make --inputglob and --outputcheck work on their own Apr 8, 2024
@justkey007 justkey007 merged commit e166548 into justkey007:master May 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants