-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify deployment #498
Labels
Milestone
Comments
For compatibility we might need a state variable such as "use_jp_core=False" which is defined in the new jpcore package. The idea is to alway import jpcore before the legacy justpy thus initialization of jpcore concepts is possible. |
A jpconfig package might be the way to go to avoid cyclic dependencies ... |
see pypa/hatch#464 for followup problems |
see #685 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to https://github.com/justpy-org/justpy/blob/master/docs/tutorial/deployment.md
is the official way of deployment.
This "instantiation by import" approach looks simple and elegant on first few but is a potential software engineering nightmare when it comes to maintainance, testing and deployment. E.g. the current "demostarter" approach won't work because the app variable is overridden by each demo and in the end all servers show the same content on all ports - the last demo "wins" the content for ressources.
It would be much better to have a JpApp and JpServer object - automatically providing a JpServer if it is not specified
for the simple case
simple
advanced
The text was updated successfully, but these errors were encountered: