Add docker env for local development #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 similar comments
auvipy
requested changes
Jan 3, 2021
|
|
||
| ENV PATH /home/app/venv/bin:${PATH} | ||
|
|
||
| RUN python3 -m venv ~/venv && \ |
There was a problem hiding this comment.
do we really need to use virtualenv with docker?
There was a problem hiding this comment.
I prefer to have my Docker setup as close as possible to my production setups which use virtualenvs.
But can be removed if you don't like it.
There was a problem hiding this comment.
wondering why didn't we consider using FROM python:3.8-slim-buster?
| @@ -0,0 +1,17 @@ | |||
| version: "3.5" | |||
There was a problem hiding this comment.
It's the Compose file format version, see https://docs.docker.com/compose/compose-file/
auvipy
approved these changes
Jan 11, 2021
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To simplify local development and reduce the need to have virtualenv and other libs installed, this PR adds a simple docker container to run tests in.