Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django ReST Framework #503

Merged
merged 73 commits into from
Feb 11, 2023
Merged

Django ReST Framework #503

merged 73 commits into from
Feb 11, 2023

Conversation

justquick
Copy link
Owner

@justquick justquick commented Mar 1, 2022

  • Dynamic serializers and viewsets for the registered models in the actstream.registry
  • Default config for Action/Follow
  • Views to match (most) streams in the action manager
  • Ability to view your own actions
  • Custom serializer, viewset and permission options in settings
  • Related field evaluation using rest-framework-generic-relations

not ready for merge yet

#502 #286

@justquick justquick added the 2.0 Activity Streams 2.0 Spec label Mar 1, 2022
@lgtm-com
Copy link

lgtm-com bot commented Mar 1, 2022

This pull request introduces 7 alerts when merging 954181a into 34e428f - view on LGTM.com

new alerts:

  • 3 for Except block handles 'BaseException'
  • 3 for Unused import
  • 1 for Module is imported more than once

@lgtm-com
Copy link

lgtm-com bot commented Mar 1, 2022

This pull request introduces 9 alerts when merging ea5ad39 into b0d3d82 - view on LGTM.com

new alerts:

  • 4 for Except block handles 'BaseException'
  • 4 for Unused import
  • 1 for Module is imported more than once

@lgtm-com
Copy link

lgtm-com bot commented Mar 1, 2022

This pull request introduces 9 alerts when merging 704f1f3 into b0d3d82 - view on LGTM.com

new alerts:

  • 4 for Except block handles 'BaseException'
  • 4 for Unused import
  • 1 for Module is imported more than once

@lgtm-com
Copy link

lgtm-com bot commented Aug 7, 2022

This pull request introduces 10 alerts when merging e30d1cb into 9115494 - view on LGTM.com

new alerts:

  • 5 for Except block handles 'BaseException'
  • 5 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Aug 7, 2022

This pull request introduces 10 alerts when merging 4eed673 into 9115494 - view on LGTM.com

new alerts:

  • 5 for Except block handles 'BaseException'
  • 5 for Unused import

@coveralls
Copy link

coveralls commented Aug 7, 2022

Coverage Status

Coverage: 94.972% (-0.3%) from 95.23% when pulling 1d7b225 on drf into 890d13f on main.

@lgtm-com
Copy link

lgtm-com bot commented Aug 7, 2022

This pull request introduces 10 alerts when merging 25b6e83 into c39808d - view on LGTM.com

new alerts:

  • 5 for Except block handles 'BaseException'
  • 5 for Unused import

@auvipy
Copy link
Collaborator

auvipy commented Aug 15, 2022

is there any work remain from your side?

@justquick
Copy link
Owner Author

i need to see how dependent this needs to be on drf_spectacular.... it's a great feature but should be optional. id like to publish the output schema api explorer it generates somewhere but it shouldnt b required when running tests or anything else. those parts also need some work but can probably wait

@lgtm-com
Copy link

lgtm-com bot commented Oct 15, 2022

This pull request introduces 10 alerts when merging 674126a into dd097fc - view on LGTM.com

new alerts:

  • 5 for Except block handles 'BaseException'
  • 5 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Oct 15, 2022

This pull request introduces 10 alerts when merging 4fa7754 into dd097fc - view on LGTM.com

new alerts:

  • 5 for Except block handles 'BaseException'
  • 5 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Oct 15, 2022

This pull request introduces 10 alerts when merging 93940ba into dd097fc - view on LGTM.com

new alerts:

  • 5 for Except block handles 'BaseException'
  • 5 for Unused import

@justquick
Copy link
Owner Author

im really tempted to merge this now but there are a couple things lacking. this really needs better tests and documentation. also we should push the openapi standard and provide a redoc site iamo. here's a run i did for the actstream drf api spec.

https://justquick.io/django-activity-stream/redoc.html?

@auvipy
Copy link
Collaborator

auvipy commented Nov 5, 2022

I checked the doc, what more you intended to complete?

@justquick
Copy link
Owner Author

we need to have a guide in the django-activity-stream documentation about how to use drf in actstream. just a page in the docs describing how to access it is enough. ill take a hack at something

i also want to strip the spectacular stuff out of the test app. just seems overkill and confusing. will add it in a later release

Repository owner deleted a comment from netlify bot Nov 20, 2022
@justquick
Copy link
Owner Author

there are also changes to the ACTSTREAM_SETTINGS that add a DRF section which also needs documenting. hoping to finish this up soon

@justquick justquick merged commit 1d7b225 into main Feb 11, 2023
@justquick
Copy link
Owner Author

decided to rip off the bandaid and put this into main. please check it out and if there arent any issues then ill cut a 2.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 Activity Streams 2.0 Spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DRF support jquery ajax follow/unfollow
4 participants