Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mysql details from docstring #511

Merged
merged 2 commits into from
Jul 5, 2022
+6 −5
Merged

Remove mysql details from docstring #511

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
135ace8
Remove mysql details from docstring
cb109 Jun 30, 2022
e5fc402
Fix typos
cb109 Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions actstream/jsonfield.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@

Decide on a JSONField implementation based on available packages.

There are two possible options, preferred in the following order:
- JSONField from django-jsonfield with django-jsonfield-compat
- JSONField from django-mysql (needs MySQL 5.7+)
These are the options:
- With recent Django >= 3.1 use Django's builtin JSONField.
- For Django versions < 3.1 we need django-jsonfield-backport
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dropped support below django 3.2

and will use its JSONField instead.

Raises an ImportError if USE_JSONFIELD is True but none of these are
installed.
Raises an ImportError if USE_JSONFIELD is True, but none of the above
apply.

Falls back to a simple Django TextField if USE_JSONFIELD is False,
however that field will be removed by migration 0002 directly
Expand Down