-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test-logger extension #432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you pls check if we can implement it by subclassing DefaultLogger
instead to avoid duplicate logic?
I intended to (that is why it is still in WIP, after all subclassing DefaultLogger will require some visibility changes in the logger) |
Ah wait, that will cause the dependency cycle again, right? Maybe we can move the default logger somewhere else? |
- Fixed visibility of methods/interface
Yes you are right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I have another use-case in mind: a program using Jayvee might want to extract the logs (instead of reading the std out).
Could you move it from the test to the regular library.
Another suggestion: store all logs in a common string array of a wrapper that lets you filter the different log levels. This way the order of log messages is preserved between the different log levels.
I could do that, but would do so in a separate PR given that this is another feature. |
This adds some additional functionality to the
test-logger
as discussed #430 (comment)