Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinity number parsing fix #457

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Infinity number parsing fix #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/extensions/std/exec/src/text-range-selector-executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export class TextRangeSelectorExecutor extends AbstractBlockExecutor<

context.logger.logDebug(
`Selecting lines from ${lineFrom} to ${
lineTo === Number.POSITIVE_INFINITY || lineTo >= numberOfLines
lineTo === Number.MAX_SAFE_INTEGER || lineTo >= numberOfLines
? 'the end'
: `${lineTo}`
}`,
Expand Down
2 changes: 1 addition & 1 deletion libs/extensions/std/lang/src/text-range-selector-meta-inf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export class TextRangeSelectorMetaInformation extends BlockMetaInformation {
},
lineTo: {
type: PrimitiveValuetypes.Integer,
defaultValue: Number.POSITIVE_INFINITY,
defaultValue: Number.MAX_SAFE_INTEGER,
validation: greaterThanZeroValidation,
},
},
Expand Down
2 changes: 1 addition & 1 deletion libs/language-server/src/lib/ast/wrappers/cell-range-wrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import {
columnIndexAsCharacters,
} from './util/column-id-util';

export const LAST_INDEX = Number.POSITIVE_INFINITY;
export const LAST_INDEX = Number.MAX_SAFE_INTEGER;

export class CellIndex {
constructor(
Expand Down
2 changes: 1 addition & 1 deletion libs/language-server/src/lib/constraint/length-constraint-meta-inf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export class LengthConstraintMetaInformation extends ConstraintMetaInformation {
},
maxLength: {
type: PrimitiveValuetypes.Integer,
defaultValue: Number.POSITIVE_INFINITY,
defaultValue: Number.MAX_SAFE_INTEGER,
validation: nonNegativeValidation,
},
},
Expand Down
4 changes: 2 additions & 2 deletions libs/language-server/src/lib/constraint/range-constraint-meta-inf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ export class RangeConstraintMetaInformation extends ConstraintMetaInformation {
{
lowerBound: {
type: PrimitiveValuetypes.Decimal,
defaultValue: Number.NEGATIVE_INFINITY,
defaultValue: Number.MIN_SAFE_INTEGER,
},
lowerBoundInclusive: {
type: PrimitiveValuetypes.Boolean,
defaultValue: true,
},
upperBound: {
type: PrimitiveValuetypes.Decimal,
defaultValue: Number.POSITIVE_INFINITY,
defaultValue: Number.MAX_SAFE_INTEGER,
},
upperBoundInclusive: {
type: PrimitiveValuetypes.Boolean,
Expand Down
Loading