Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MetaInf to TypedObjectWrapper #460

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

georg-schwarz
Copy link
Member

@georg-schwarz georg-schwarz commented Nov 3, 2023

Builds on #459. Diff for increment here.

  • No change of logic
  • Renames MetaInformation to TypedObjectWrapper, implementing the AstNodeWrapper interface
  • Renames BlockMetaInformation to BlockTypeWrapper
  • Renames CompositeBlockMetaInformation to CompositeBlockTypeWrapper
  • Renames ConstraintMetaInformation to ConstraintTypeWrapper
  • Move renamed files into language-server/src/lib/ast/wrappers/typed-object directory
  • Renamed variable use

I noticed some flaky tests locally. Probably not due to this PR. I suspect synchronicity issues in the test setup.

@georg-schwarz georg-schwarz merged commit cc04be9 into main Nov 7, 2023
2 checks passed
@georg-schwarz georg-schwarz deleted the refactor-meta-inf-wrapper branch November 7, 2023 12:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants