Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalFileExtractor #519

Merged
merged 4 commits into from
Feb 7, 2024
Merged

LocalFileExtractor #519

merged 4 commits into from
Feb 7, 2024

Conversation

rhazn
Copy link
Contributor

@rhazn rhazn commented Feb 6, 2024

Adding a LocalFileExtractor block to extract files from the local file system. Based on the SEMI work by @OmarFourati in #478.

Closes #393

To review only my changes since #478, use this link: https://github.com/jvalue/jayvee/pull/519/files/e0179407e5b98b751c29df69db9f1fd1a26cbee5..62a7c8e3df995a7f3a643a19dec1b23d76cc424c

Moved changes from old PR that is now out of sync with main (#478) to a fresh PR, based on latest main commit.

Co-authored-by: OmarFourati <fourati.omar@gmail.com>
Copy link
Member

@georg-schwarz georg-schwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@rhazn rhazn merged commit 3874ff1 into main Feb 7, 2024
3 checks passed
@rhazn rhazn deleted the issue-393 branch February 7, 2024 10:58
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Extract files from local file system
2 participants