Use camel case for value type (valueType) internally #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joluj
reviewed
Apr 9, 2024
Probably not. Reverted the changes on them. |
joluj
approved these changes
Apr 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First steps towards #454.
This PR introduces consistent naming of classes and variables; only in code.
Does not fix all occurrences in the docs. We should update the docs consistently, e.g., using
block typesinstead ofBlockTypesas well. Otherwise, the docs make an inconsistent impression. I touched the docs at a few places but left out the very obvious ones where a deviating naming scheme jumps to the eye immediately.I suggest refactoring the docs before making the code used for
blockType, etc, consistent.