fix(FilePicker): path can now start with a dot

[TungstnBallon]

paths inside FilePicker can now start with a dot

block DataPicker oftype FilePicker {
	path: "./data.csv";
}

closes #381

[rhazn]

If possible, a great practice when fixing bugs is:

• Create a unit test that fails with the current bug (here, create a test for the FilePicker blocktype that fails with a leading dot path)
• Fix the bug

This workflow ensures that the first time a bug is reported it is the last time a human encounters it.

In this case, I think we have unit tests for block types so I'd ask you to add one for this situation. That can be in a separate PR though, after merging this one. You can use "references #381" in the description of that PR to make sure they are nicely linked

[rhazn]

(In case you'd like me to review this again, please re-request a review on the top right @TungstnBallon :)).

[georg-schwarz]

Hey @TungstnBallon,

Sorry that this happened the second time now, but there has been a refactoring again 😅
#545 renamed all occurrences of "blocktype" to "blockType", it probably affects some of your imports.
#546 enforces the use of type imports where possible; the auto-fix feature of eslint should be pretty helpful here.

Let me know if I can help updating the branch ;-)

[TungstnBallon]

is there an advantage to putting the tests in a separate pull request? @rhazn

[rhazn]

No advantage to do it in a separate PR in general (in fact, changes and their tests should be in one PR). But sometimes it is better to get a smaller PR merged as soon as possible and move related work to future PRs. For example to avoid what happened here with Georg making changes that conflicted with yours in the meantime.

I wasn't sure if you'd need more time to figure out how testing in Jayvee works, but it looks like it went fast so great job 👍.

You can merge this, I'd squash and merge it so it becomes one consistent commit though.