Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jayvee goes ESM (Langium Upgrade) #558

Merged
merged 39 commits into from
May 6, 2024
Merged

Conversation

georg-schwarz
Copy link
Member

@georg-schwarz georg-schwarz commented May 3, 2024

Closes #427. Upgrade Langium and switch to ESM as a necessary evil.

  • Switch from CommonJS to ESM as Langium 2.0 switched to ESM.
  • Most libraries and apps now use esbuild as we found other tools like rollup and vite to not work out of the box with our setup.
  • Extract docs generation from docs app into new app docs-generator so that the docs can stay with CommonJS
  • Migrated tests to use vitest instead of jest due to ESM compatibility issues.
  • Add linter rules to prevent some of the import-related pitfalls we found along the way migrating to ESM.
  • Adjusted the docs where necessary.

@georg-schwarz georg-schwarz force-pushed the jayvee-goes-esm-esbuild branch from 0a6ac04 to a7c9b8c Compare May 3, 2024 09:54
@georg-schwarz georg-schwarz marked this pull request as ready for review May 6, 2024 12:39
package.json Outdated Show resolved Hide resolved
apps/docs-generator/src/main.ts Show resolved Hide resolved
apps/docs/project.json Outdated Show resolved Hide resolved
libs/extensions/rdbms/exec/tsconfig.spec.json Outdated Show resolved Hide resolved
@georg-schwarz georg-schwarz merged commit 70125ca into main May 6, 2024
3 checks passed
@georg-schwarz georg-schwarz deleted the jayvee-goes-esm-esbuild branch May 6, 2024 13:19
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Update Langium to 2.0
3 participants