-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jayvee goes ESM (Langium Upgrade) #558
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georg-schwarz
force-pushed
the
jayvee-goes-esm-esbuild
branch
from
May 3, 2024 09:54
0a6ac04
to
a7c9b8c
Compare
georg-schwarz
commented
May 6, 2024
rhazn
approved these changes
May 6, 2024
georg-schwarz
commented
May 6, 2024
georg-schwarz
commented
May 6, 2024
joluj
approved these changes
May 6, 2024
joluj
approved these changes
May 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #427. Upgrade Langium and switch to ESM as a necessary evil.
esbuild
as we found other tools likerollup
andvite
to not work out of the box with our setup.docs
app into new appdocs-generator
so that thedocs
can stay with CommonJSvitest
instead ofjest
due to ESM compatibility issues.