-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple file import #564
Merged
Merged
Simple file import #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to free the keyword "use" for imports
georg-schwarz
commented
May 16, 2024
Merged
joluj
reviewed
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
A test for transitive imports would be nice (A imports B, B imports C; Assert that A can use stuff from B).
libs/language-server/src/lib/validation/checks/import-definition.ts
Outdated
Show resolved
Hide resolved
…es (including transitive imports)
joluj
approved these changes
May 17, 2024
rhazn
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing. 👍
libs/language-server/src/lib/validation/checks/import-definition.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #563: Introduces
use
functionality with wildcards to load elements from other files.use * from "relative/path/file.jv"
use
property of block typeTableTransformer
touses
, otherwise the new keyworduse
would be ambiguousparseTestFileInWorkingDir
that allows loading the test files with their working directory instead of only reading the single file. This is a competing test setup with the usedparseHelper
function. We should discuss whether we need two separate test setups or if this one should be applied everywhere.Future Work
I tried to keep the PR short, so here an outlook of what's next
I see the follow-up tasks before tackling further import features:
I see the next import features to be:
publish
elements instead of publishing alluse
elements instead of using a wildcard