-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add publish
keyword
#571
Add publish
keyword
#571
Conversation
/** | ||
* Follow an export statement to its original definition. | ||
*/ | ||
protected followExportDefinitionChain( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we should ever allow publish * from '{path}'
, we'd have to use recursion here I think to follow the chain.. Right now, the exported element is directly referenced.
… distributing the publish keyword
1a2dc82
to
4fef7c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a high level look, overall looks good to me, great work 👍 . Just some small codestyle / optional comments.
Partially addresses #563: Introduces
publish
keyword.As discussed in eclipse-langium/langium#1508 (reply in thread), the main logic resides in the
JayveeScopeProvider
instead of theJayveeScopeComputation
.Notes