Fix pipeline stacktrace syntax error on CI. #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok! I can now reproduce it locally by updating my node docker image from 14.15.1 to 14.17.0. This is so much fun! |
|
It seems to have to do with nodejs/node#33491 introduced into NodeJS version 14.17.0: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md#2021-05-11-version-14170-fermium-lts-danielleadams I disabled source maps and now it works? Uhhh... |
georg-schwarz
previously approved these changes
May 25, 2021
lunedis
force-pushed
the
fix_pipeline_ci_error
branch
from
28293c0
to
5be346c
Compare
georg-schwarz
approved these changes
May 25, 2021
lunedis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created to solve the failing CI test here: https://github.com/jvalue/open-data-service/runs/2646300675?check_suite_focus=true
and also here: https://github.com/jvalue/open-data-service/runs/2662359092
I was not able to reproduce the error locally, so I opened this PR in order to run my changes on the CI.