Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🥧 update NEON SIMD #25

Merged
merged 7 commits into from
Feb 11, 2023
Merged

🥧 update NEON SIMD #25

merged 7 commits into from
Feb 11, 2023

Conversation

jvdd
Copy link
Owner

@jvdd jvdd commented Feb 11, 2023

Fixed the merge issues of #24

With a lot of patience I debugged & updated the NEON code on my raspberry pi 3 🙃
image

Thx for the headstart @varon :)


This PR also fixes a bug in the tests in where we checked for the wrong target feature (and thus performed illegal instructions)

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 11, 2023

CodSpeed Performance Report

Merging #25 varon-neon-nan-v3 (ccf0f8f) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 44 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@jvdd jvdd changed the title Update NEON SIMD 🥧 update NEON SIMD Feb 11, 2023
@jvdd jvdd merged commit d8da46c into nans_v3 Feb 11, 2023
@jvdd jvdd deleted the varon-neon-nan-v3 branch March 26, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants