Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: architecture - use type-state pattern #35

Merged
merged 8 commits into from
Mar 4, 2023
Merged

refactor: architecture - use type-state pattern #35

merged 8 commits into from
Mar 4, 2023

Conversation

jvdd
Copy link
Owner

@jvdd jvdd commented Mar 4, 2023 •
edited
Loading

Make the architecture more flexible;

  • less duplicate code
  • more clear how traits + structs interoperate

To achieve the type-state pattern is applied for the

  • SIMD structs in simd/config.rs
  • SCALAR struct in scalar/generic.rs

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 4, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #35 architecture_update (085087c) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 52 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@jvdd jvdd changed the title refactor: architecture update refactor: architecture update - use type-state pattern Mar 4, 2023
@jvdd jvdd changed the title refactor: architecture update - use type-state pattern refactor: architecture - use type-state pattern Mar 4, 2023
@jvdd jvdd merged commit 6eedc1f into main Mar 4, 2023
@jvdd jvdd mentioned this pull request Mar 4, 2023
Merged
@jvdd jvdd deleted the architecture_update branch March 26, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jvdd