Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add 64-bit aarch64 SIMD implementation #52

Merged
merged 16 commits into from
Apr 18, 2023
Merged

feat: add 64-bit aarch64 SIMD implementation #52

merged 16 commits into from
Apr 18, 2023

Conversation

jvdd
Copy link
Owner

@jvdd jvdd commented Apr 15, 2023 •
edited
Loading

Closes #51

  • Add SIMD implementations + trigger tests
  • i64 -> unstable
  • u64 -> unstable
  • f64 ignore nan -> stable 🎉
  • f64 return nan -> unstable

Other TODO's

  • Update benchmarks
    • check for new compilation scheme for 64-bit aarch64

Also a big thanks to @matdemeue for lending me a rpi4, allowing to tune & validate the aarch64 code

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 15, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #52 aarch64_64bit_simd (5b51457) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 168 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@jvdd jvdd changed the title feat: add u64 & i64 aarch64 SIMD implementation feat: add 64-bit aarch64 SIMD implementation Apr 16, 2023
jvdd
jvdd commented Apr 17, 2023
View reviewed changes
Copy link
Owner Author

@jvdd jvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙃

@jvdd jvdd merged commit 5f45db3 into main Apr 18, 2023
@jvdd jvdd deleted the aarch64_64bit_simd branch June 3, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: add 64-bit aarch64 simd
1 participant
@jvdd