Rename ref property to reference

[mathiasbynens]

Ref. #57.

[mathiasbynens]

@jviereck After this is merged, could you bump the version number again please? Then regjsgen can be updated accordingly and publish a new release as well.

[jviereck]

Good catch! Now that I see this PR, how about instead of

{
  "type": "reference",
  "reference": 1
}

do

{
  "type": "reference",
  "matchIndex": 1
}

Reasoning:

1. get away with the duplication "reference" there
2. just calling the property "reference=1" has low semantics. What is referred? Calling it "matchIndex" makes it a little bit more clear in my opinion.

I don't have strong opinions on this and either solution is fine for me. Thought it's worth bringing it up here as it came to my mind when reviewing the PR.

[mathiasbynens]

@jviereck Agreed. Patch updated.

[jviereck]

Wow, that was fast 👍

Sorry to spot this just now, but I guess for consistency, the variable on the function name should then also be renamed? From

function createReference(reference) {

to

function createReference(matchIndex) {

Let me know what you think. Happy to do the change myself if you agree on the change as it's my fault i didn't spot this from the beginnig :/

[mathiasbynens]

No worries. Updated the patch. Oh, and I should’ve spotted this during review in the first place!

[jviereck]

okay, I tried to automate the release process to NPM, but failed. Seems like it's possible to configure travis to push a new version to npm following the instructions in 1. I did this and updated the .travis.yml file in the repo according this the documentation. However, when tagging the new release, I get this at the end of the travis run:

https://travis-ci.org/jviereck/regjsparser/jobs/34053640#L593

Skipping deployment with the npm provider because this branch is not permitted to deploy

Any idea what I did wrong here?

---

To not block the new release, I published the 0.1.2 release to npm manually.

[mathiasbynens]

I made some changes based on my interpretation of that document: 88dfcee Not sure if it works though. Let’s test it when the next version gets tagged :)