-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General dependency upgrades/bump #72
General dependency upgrades/bump #72
Conversation
…g `--prefer-lowest` ranges
Ah, I forgot to run phpstan locally -.- My bad |
@WyriHaximus hopefully something you'd like :D |
@Ocramius Yes I do love this! Thank you. The only issue I need to fix is that it requires Scrutinizer to be green and that seems to error out 😂 |
Kill Scrutinizer! We already run SA and whatnot, no? :P |
Nvm, changed its config: let's see if it works :) |
@WyriHaximus it is done. |
I wouldn't mind, but I'm only maintaining this repo. I can't make those changes, that is up to @jwage. |
|
OOOOOOOOOOF. Not on a computer that can perform signed commits, sorry :-\ |
No need to say sorry, just ping me when you are and pushed it with signed commits :). |
Looks like signed commits were enabled relatively recently: no signed commits in Let's wait for @jwage's feedback then. |
I disabled the signed commits requirement. I am good with killing Scrutinizer too. I am not using it anywhere anymore. No need 👍 Thanks! |
@WyriHaximus your call now 👍 |
@@ -17,11 +17,9 @@ | |||
|
|||
final class IssueClientTest extends TestCase | |||
{ | |||
/** @var RequestFactoryInterface|MockObject */ | |||
private $messageFactory; | |||
private RequestFactoryInterface&MockObject $messageFactory; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oeoeoeoeoeoe!
@Ocramius Looks good to me. Lets kill Scrutinizer in a follow up PR |
Thanks @WyriHaximus! Think this is releasable meanwhile? CI runs on scrutinizer too, so far. |
Working on releasing this now |
This is just a general dependency upgrade:
<8.1
symfony/console:^6
(^5
preserved, so that a seamless upgrade is possible for now - to be dropped later)final
marker on some critical classesAllows following upgrades: