- dropped SKIP_EMPTY and READ_AHEAD due to strange behavior when using c... #25
Conversation
…g current(), seek(), and rewind(). Skipped empty rows instead with code. - getLineNumber now uses SplFileObject::key() for accurate numbers - getLastLineNumber(), for possibly splitting up a large CSV file and processing in a queue - getCurrentRow() to accurately get a array from the current line - advanceTo() to move to a file line - setHeaderLine() to set a header line that's not the first row - removed incrementLine() since the core is using SplFileObject for seeking, the method would make line numbers inaccurate - rowIsEmpty() to check if it's a completely empty line or empty with delimiters - Unit tests and fixtures to test all new and refactored behavior
| /** | ||
| * @dataProvider getReadersNoHeadersFirstRow | ||
| */ | ||
| public function testGetLastLineNumberNoHeadersFirstRow( Reader $reader ) |
There was a problem hiding this comment.
would be good to remove these spaces around, you can also see https://github.com/fabpot/php-cs-fixer
|
@cordoval ok. Took care of those. |
| */ | ||
| public function getLastLineNumber() | ||
| { | ||
| if( $this->lastLine !== false ) { |
|
Just a few coding standard/formatting issues. |
|
@jwage alright. How does this look now? I ran the php-cs-fixer that was suggested up top. |
|
@jwage just giving this a little bump |
| /** | ||
| * @var bool | ||
| */ | ||
| private $headerLine = false; |
There was a problem hiding this comment.
Add a space between this property and the doc block below.
|
👍 |
|
I will merge if you can just fix those two spacing issues. |
|
@jwage Badda bing. Badda boom. |
- dropped SKIP_EMPTY and READ_AHEAD due to strange behavior when using c...
|
Thanks for your contribution! :) |
|
You're welcome! What coding style are you using? On Sep 5, 2014, at 11:48 AM, "Jonathan H. Wage" notifications@github.com wrote:
|
This is a pretty major shift in the core code so if you see any issues let me know. I got about 87% official coverage from Xdebug for the Reader class, but I'm sure it's more. For some reason the constructor is getting called, but the code coverage doesn't show that those lines are getting called.