-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utf8 bom for ms excel #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jwage ping |
I agree and I want to learn more |
@jwage ping |
1 similar comment
@jwage ping |
good |
@jwage ping |
@jwage you may merge my pull request? |
👍 sorry for the delay. |
Hussain @ # |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Jonathan!
In one of my project I have a problem with cyrillic symbols in generated CSV-file.
We have simple source:
And when we open it CSV-file in MS Excel take this:
For solve this problem I do this PR. Now you may set flag
$isNeedBOM
for give knowWriter
to insert UTF-8 BOM symbol in start CSV-file. When you do reading this CSV-file we checks exists UTF-8 BOM symbol and if it true - remove from first line.Some source:
Give us good result on MS Excel:
I add small tests for this PR and if you see any more tests I will be add its.