Require PHP 7.1, add phpstan, Doctrine coding standards, add scrutini… #38
Conversation
jwage
force-pushed
the
code-cleanup
branch
3 times, most recently
from
9ca129c to
b08f65e
Compare
| protected $enclosure = '"'; | ||
|
|
||
| /** | ||
| * @param string[] $initialHeaders |
There was a problem hiding this comment.
The parameters are $path, $modeand $isNeedBOM.
They're needed to add the @param in that doc block.
There was a problem hiding this comment.
I am adopting the https://github.com/doctrine/coding-standard in this project and it requires only having doc blocks for parameters that can't be hinted by the PHP language itself.
| /** | ||
| * @param $path | ||
| * @param string $mode | ||
| * @param bool $headersInFirstRow |
There was a problem hiding this comment.
Can you explain why remove these doc blocks?
There was a problem hiding this comment.
Because the type hints in the PHP language define everything needed so the doc blocks are not required.
| } | ||
|
|
||
| /** | ||
| * @param $lineNumber zero-based index |
There was a problem hiding this comment.
It's the same question as the previous comment.
tests/bootstrap.php
Outdated
| @@ -1,3 +1,5 @@ | |||
| <?php | |||
|
|
|||
| declare(strict_types=1); | |||
There was a problem hiding this comment.
The declare(strict_types=1); is added in the every related Tests methods currently.
This bootstrap file seems to be useless and it should change this approach to adding the vendor/autload.php in bootstrap attribute for the phpunit tag in phpunit.xml.dist file.
Here is the example:
<phpunit bootstrap="./vendor/autoload.php" colors="true">
There was a problem hiding this comment.
Agree. I will make that change.
…zer and update travis ci.
…zer and update travis ci.